Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min/max in useCounter? #273

Closed
tim-phillips opened this issue Apr 25, 2019 · 2 comments
Closed

min/max in useCounter? #273

tim-phillips opened this issue Apr 25, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@tim-phillips
Copy link

Would it be in this library's interest to add an option for setting minimum and maximum values in useCounter? Or is this better handled in the UI with a disabled button state?
@streamich
Copy link
Owner

Yes, min/max sounds like something that can be added to useCounter.

@streamich streamich added the enhancement New feature or request label Jun 1, 2019
xobotyi added a commit that referenced this issue Aug 13, 2019
@xobotyi
Implemented #273;
1628e57 
Added runtime type checks;
Tests for all that stuff;
Docs;
@xobotyi xobotyi mentioned this issue Aug 13, 2019
Merged
streamich added a commit that referenced this issue Aug 17, 2019
@streamich
Merge branch 'master' into #273-impl
909f9bd
@streamich
Copy link
Owner

Done in #519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tim-phillips @streamich