Virtual camera custom sources #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l camera custom sources
summeroff
reviewed
Nov 20, 2024
| @@ -1181,7 +1181,7 @@ bool obs_transition_audio_render_do(obs_source_t *transition, uint64_t *ts_out, | |||
| if (!transition_valid(transition, "obs_transition_audio_render")) | |||
| return false; | |||
|
|
|||
| blog(LOG_INFO, "[AUDIO_CANVAS] obs_transition_audio_render_do started"); | |||
| //blog(LOG_INFO, "[AUDIO_CANVAS] obs_transition_audio_render_do started"); | |||
There was a problem hiding this comment.
we do not need this commented logging. you can remove it.
summeroff
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refined code a little to be compatible with new feature: custom sources for virtual camera
Motivation and Context
I restored original interface of few functions which work with media for them to be compatible with this new feature.
How Has This Been Tested?
Manually, Windows only
Types of changes
obs-noderepo was modified accordingly