Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Past visit' table #12

Merged
merged 4 commits into from
Mar 27, 2017
Merged

Add 'Past visit' table #12

merged 4 commits into from
Mar 27, 2017

Conversation

straylightlabs
Copy link
Collaborator

@straylightlabs straylightlabs commented Mar 23, 2017

No description provided.

@straylightlabs straylightlabs requested a review from tajftw March 23, 2017 04:18
@straylightlabs
Copy link
Collaborator Author

@tajftw Should we still have "Actions" column for Past visit table?

@tajftw
Copy link
Collaborator

tajftw commented Mar 23, 2017

@skywhale there should still be actions to 'Duplicate' (create a new event for the same guest with a different date and time) and 'Edit' (modify the old event in case it was missed and the date simply needs to be moved forward).

@straylightlabs
Copy link
Collaborator Author

straylightlabs commented Mar 24, 2017

@tajftw thanks. "duplicate" sounds like a new feature request, so here it is. https://app.asana.com/0/260679654120467/302232833758142

I added back "edit" link. Please give LGTM if it looks good.

Please use this link to see the diffs (added "w=1") since I also made some indentation changes.
https://github.com/straylightlabs/straylightportal/pull/12/files?w=1

@straylightlabs
Copy link
Collaborator Author

straylightlabs commented Mar 24, 2017

The demo server is up running at:
https://straylight.jp/connect-dev

It's reading a dev database, so you'll need to go through onboarding flow once again. you can put random stuff.

@skywhale
Copy link
Collaborator

BTW I should switch back to "skywhale" :)

@skywhale
Copy link
Collaborator

@tajftw I'll go ahead and merge. Plz feel free to let me know if you have issues or concerns.

@skywhale skywhale merged commit 48e868c into master Mar 27, 2017
@skywhale skywhale deleted the 296944783539129 branch March 27, 2017 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants