Prevent the debug server from setting up its own event loop #945
Conversation
DoctorJohn
force-pushed
the
let-the-debug-server-reuse-the-default-event-loop
branch
from
338005b to
0247153
Compare
DoctorJohn
changed the title
Codecov Report
@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 97.41% 97.52% +0.10%
==========================================
Files 76 76
Lines 2592 2705 +113
Branches 362 378 +16
==========================================
+ Hits 2525 2638 +113
Misses 41 41
Partials 26 26 |
| @@ -57,4 +57,4 @@ def server(schema, host, port, app_dir): | |||
| app.add_websocket_route(path, graphql_app) | |||
|
|
|||
| print(f"Running strawberry on http://{host}:{port}/ 🍓") | |||
| uvicorn.run(app, host=host, port=port, log_level="error") | |||
| uvicorn.run(app, loop="none", host=host, port=port, log_level="error") | |||
There was a problem hiding this comment.
Is this documented in the uvicorn docs? I was only able to find it here: https://github.com/encode/uvicorn/blob/bf1c64e2c141971c546671c7dc91b8ccf0afeb7d/uvicorn/config.py#L55-L60
I'll test this with the dataloader example and see if it works :)
Thank you!
There was a problem hiding this comment.
It appears to be undocumented on their website which matches the uvicorn cli help command. Maybe it was intended for programmatically usage only. However, according to this PR they added it specifically to allow the setup of custom event loops.
|
Thanks for adding the Here's a preview of the changelog: This releases fixes an issue with the debug server that prevented the |
DoctorJohn
deleted the
let-the-debug-server-reuse-the-default-event-loop
branch
Description
This PR is a possible fix for #940. It configures
uvicornto not create its own event loop. This way thestrawberry.dataloader.DataLoader.loopwould be the same as the loop used byuvicorn.While I would probably not configure
uvicornthe same way in production code, I think it's the simplest (maybe the only) way to make dataloaders work with the debug server command.Types of Changes
Issues Fixed or Closed by This PR
Checklist