add optional extensions to GraphQLHTTPResponse

[lijok]

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

• Return extensions results from our view #589

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[lijok]

Not sure of the best place to add tests for this?

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

This release adds an extensions field to the GraphQLHTTPResponse type and also exposes it in the view's response.

This field gets populated by Strawberry extensions: https://strawberry.rocks/docs/guides/extensions#get-results

[codecov]

Codecov Report

Merging #903 (7facfe0) into main (cb853ed) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   97.07%   97.51%   +0.43%     
==========================================
  Files          72       76       +4     
  Lines        2430     2737     +307     
  Branches      345      382      +37     
==========================================
+ Hits         2359     2669     +310     
+ Misses         43       42       -1     
+ Partials       28       26       -2     

[patrick91]

@lijok looks good to me! I think we should add test for all our integrations, what do you think? :)

[lijok]

@lijok looks good to me! I think we should add test for all our integrations, what do you think? :)

This is what I was wondering, where best would it be to add tests for these?
New ones or extend existing ones?

[patrick91]

@lijok looks good to me! I think we should add test for all our integrations, what do you think? :)

This is what I was wondering, where best would it be to add tests for these?
New ones or extend existing ones?

new ones 😊

[lijok]

@patrick91 this should be ready now

[BryceBeagle]

This is marked Optional but can never be None. Should we be setting data["extensions"] = None if there aren't any? (this would apply to data and errors too.)

[patrick91]

data and errors already work like that, for extensions we always return a dict:

strawberry/strawberry/extensions/runner.py

Lines 50 to 56 in 98b4e67

	def get_extensions_results(self) -> Dict[str, Any]:
	data = {}
	for extension in self.extensions:
	data.update(extension.get_results())
	return data

I think we can keep them as optional, I'm not sure if we will change the dict to None at somepoint (for example if there's no extension). So I'd say this is fine :)

We can always update this in another PR :)

[patrick91]

Looks good to me 😊 I think we can merge it!

Feel free to request a sticker here: https://forms.gle/dmnfQUPoY5gZbVT67 ✨

[patrick91]

data and errors already work like that, for extensions we always return a dict:

strawberry/strawberry/extensions/runner.py

Lines 50 to 56 in 98b4e67

	def get_extensions_results(self) -> Dict[str, Any]:
	data = {}
	for extension in self.extensions:
	data.update(extension.get_results())
	return data

I think we can keep them as optional, I'm not sure if we will change the dict to None at somepoint (for example if there's no extension). So I'd say this is fine :)

We can always update this in another PR :)

[DoctorJohn]

@patrick91 I think #589 can be closed now.