Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make graphql_ws test less timing-sensitive. #2785

Merged

Conversation

kristjanvalur
Copy link
Contributor

@kristjanvalur kristjanvalur commented May 29, 2023

A fix to intermittent test failure in graphql_ws

Description

Due to timing issues on test runners, the exact number of Keepalive messages sent can vary.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #2785 (61946f7) into main (4519c39) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2785   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         198      198           
  Lines        8244     8244           
  Branches     1500     1500           
=======================================
  Hits         7952     7952           
  Misses        184      184           
  Partials      108      108           

@patrick91 patrick91 merged commit 79fdbd3 into strawberry-graphql:main May 31, 2023
@kristjanvalur
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants