Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql_transport_ws: Fix task shutdown/cancellation issues evident from testsuite warnings #2717

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

graphql_transport_ws: Fix task shutdown/cancellation issues evident from testsuite warnings #2717

wants to merge 8 commits into from
+129 −11

Commits on May 2, 2023

  1. catch current start at the beginning while loop is still active

    @kristjanvalur
    kristjanvalur committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f0b3db0 View commit details
    Browse the repository at this point in the history

  2. Close the AsyncGenerator from within the task

    @kristjanvalur
    kristjanvalur committed May 2, 2023
    Configuration menu
    Copy the full SHA
    24ca85d View commit details
    Browse the repository at this point in the history

  3. Modify comment

    @kristjanvalur
    kristjanvalur committed May 2, 2023
    Configuration menu
    Copy the full SHA
    748f6a5 View commit details
    Browse the repository at this point in the history

  4. Add unit test to verify that subscription AsyncGen is closed

    @kristjanvalur
    kristjanvalur committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ae145d6 View commit details
    Browse the repository at this point in the history

  5. Add optional code to cancel and cleanup tasks after each test run. 

    Currently disabled since it can hide other problems present.
    @kristjanvalur
    kristjanvalur committed May 2, 2023
    Configuration menu
    Copy the full SHA
    faa404f View commit details
    Browse the repository at this point in the history

  6. Increase timeout for some 3.7 weirdness

    @kristjanvalur
    kristjanvalur committed May 2, 2023
    Configuration menu
    Copy the full SHA
    daf853b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Add suggestions from code review.

    @kristjanvalur
    kristjanvalur committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b76f8b4 View commit details
    Browse the repository at this point in the history

  2. add RELEASE.md

    @kristjanvalur
    kristjanvalur committed May 3, 2023
    Configuration menu
    Copy the full SHA
    eed671e View commit details
    Browse the repository at this point in the history