Bug in JSONScalar example

[paulo-raca]

There was a bug in the JSONScalar example: parse_value takes a data structure (dicts/lists/primitives) instead of a JSON string, therefore json.loads is not necessary.

This PR started as a simple fix to the documentation, however @patrick91 suggested that we also added it into strawberry sources and tests, which I have done.

While at it, I did the same for the Base64 example -- Which I unfolded into Base16, Base32 and Base64

Finally, I also added support for the specified_by_url in scalars

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Checklist

• My change requires a change to the documentation.
• My code follows the code style of this project.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[patrick91]

good find! @paulo-raca would you mind adding a test for the JSON example? 😊

[paulo-raca]

Sure!
Would it make sense to add JSONScalar into strawberry, or should it be kept only in the documentation/tests?

[patrick91]

Sure! Would it make sense to add JSONScalar into strawberry, or should it be kept only in the documentation/tests?

I think we can add one!

Also see this comment here, the code is slightly different 🤔 #1409 (comment)

[paulo-raca]

Also see this comment here, the code is slightly different thinking #1409 (comment)

The default implementation of parse_literal is self.parse_value(value_from_ast_untyped(value)), so that implementation is basically defining a broken parse_value and then skipping it. Hacky, but it does work 👍

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

This release adds the following scalar types:

• JSON
• Base16
• Base32
• Base64

they can be used like so:

from strawberry.scalar import Base16, Base32, Base64, JSON

@strawberry.type
class Example:
    a: Base16
    b: Base32
    c: Base64
    d: JSON

---

Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Paulo Costa for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

[paulo-raca]

Sure! Would it make sense to add JSONScalar into strawberry, or should it be kept only in the documentation/tests?

I think we can add one!

I went ahead and did the same for the Base64 example -- Turns out the PR is now far from a one-line documentation fix

[github-actions]

Hi 👋 You can find a preview of the docs here:

https://strawberry.rocks/docs/pr/1647/types/scalars

[codecov]

Codecov Report

Merging #1647 (1ed772f) into main (f25ac4b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
- Coverage   98.16%   98.14%   -0.02%     
==========================================
  Files         129      129              
  Lines        4532     4540       +8     
  Branches      781      783       +2     
==========================================
+ Hits         4449     4456       +7     
  Misses         43       43              
- Partials       40       41       +1     

[patrick91]

Looks great! I've updated the release notes, I've removed the mention of the docs since they are only used for the changelog 😊

[patrick91]

shall we add an example/reason for when to use them?

[BryceBeagle]

Formatting change requests 👍

[paulo-raca]

Formatting change requests +1

All changes addressed 👍

[patrick91]

Thanks so much for this! 😊