Fix compatibility with starlette 0.18.0 and above

.github/workflows/test.yml

@@ -121,7 +121,8 @@ jobs:
     strategy:
       matrix:
         # starlette: ["0.17.1", "0.18.0", "0.19.1", "0.20.0"]
-        starlette: ["0.17.1"]
+        # fastapi doesn't support starlette 0.20.0 just yet
+        starlette: ["0.17.1", "0.18.0", "0.19.1"]
 
     name: Starlette ${{ matrix.starlette }}
     runs-on: ubuntu-latest
@@ -139,7 +140,7 @@ jobs:
       - run: poetry install
         if: steps.setup-python.outputs.cache-hit != 'true'
 
-      - name: Install django ${{ matrix.starlette }}
+      - name: Install starlette ${{ matrix.starlette }}
         run: poetry add --python ^3.10 starlette@^${{ matrix.starlette }}
 
       - name: pytest

RELEASE.md

@@ -0,0 +1,7 @@
+Release type: minor
+
+This release adds support for Starlette 0.18 and 0.19
+
+It also removes upper bound dependencies limit for starlette,
+allowing you to install the latest version without having to
+wait for a new release of Strawberry

pyproject.toml

@@ -27,7 +27,7 @@ build-backend = "poetry.masonry.api"
 
 [tool.poetry.dependencies]
 python = "^3.7"
-starlette = {version = ">=0.13.6,<0.17.0", optional = true}
+starlette = {version = ">=0.13.6", optional = true}
 click = {version = ">=7.0,<9.0", optional = true}
 pygments = "^2.3"
 uvicorn = {version = ">=0.11.6,<0.18.0", optional = true}
@@ -76,8 +76,8 @@ flake8-black = "^0.3"
 Django = ">=3.2"
 pydantic = {version = "<2", optional = false}
 email-validator = {version = "^1.1.3", optional = false}
-starlette = ">=0.13.6,<0.17.0"
-uvicorn = ">=0.11.6,<0.18.0"
+uvicorn = ">=0.11.6"
+starlette = ">=0.13.6"
 sanic = ">=20.12.2,<22.0.0"
 aiohttp = "^3.7.4.post0"
 pytest-aiohttp = "^1.0.3"

strawberry/asgi/handlers/http_handler.py

@@ -39,13 +39,9 @@ async def handle(self, scope: Scope, receive: Receive, send: Send):
         request = Request(scope=scope, receive=receive)
         root_value = await self.get_root_value(request)
 
-        sub_response = Response(
-            content=None,
-            status_code=None,  # type: ignore
-            headers=None,
-            media_type=None,
-            background=None,
-        )
+        sub_response = Response()
+        sub_response.status_code = None  # type: ignore
+        del sub_response.headers["content-length"]
 
         context = await self.get_context(request=request, response=sub_response)
 

strawberry/fastapi/router.py

@@ -251,7 +251,7 @@ def pick_preferred_protocol(self, ws: WebSocket) -> Optional[str]:
         intersection = set(protocols) & set(self.protocols)
         return min(
             intersection,
-            key=lambda i: protocols.index(i),  # type: ignore
+            key=lambda i: protocols.index(i),
             default=None,
         )
 

strawberry/types/info.py

@@ -41,6 +41,7 @@ def field_nodes(self) -> List[FieldNode]:  # deprecated
             "`info.field_nodes` is deprecated, use `selected_fields` instead",
             DeprecationWarning,
         )
+
         return self._raw_info.field_nodes
 
     @cached_property