-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cached_property
with backports.cached_property
#1582
Conversation
for more information, see https://pre-commit.ci
Thanks for adding the Here's a preview of the changelog: This release replaces Here's the preview release card for twitter: Here's the tweet text:
|
cached_property
with backports.cached_property
for more information, see https://pre-commit.ci
Co-authored-by: ignormies <[email protected]>
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 130 130
Lines 4468 4468
Branches 758 758
=======================================
Hits 4384 4384
Misses 44 44
Partials 40 40 |
@BryceBeagle can you please review the PR now |
Co-authored-by: Patrick Arminio <[email protected]>
for more information, see https://pre-commit.ci
@patrick91 I have updated your changes. Please do the review |
@RishiKumarRay thanks! We are missing the There's also a couple of failures related to mypy, can you add a type ignore on |
@patrick91 Hi, Patrick I am sorry to say but i have messed up with my repository that i forked and I also don't know how to add this , I was only able to commit your suggestions , I feel i won't be able to do |
if you want I can try to help with that on discord :) |
Yeah please let me message you there @patrick91 |
I think you can message me here -> or you can join the strawberry discord http://strawberry.rocks/discord |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks 😊
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
updated dependency to backports.cached_property
Description
Removed older cached_property
installed new backports.cached_property
updated references
Types of Changes
Issues Fixed or Closed by This PR
Closes #1517
Checklist