Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cached_property with backports.cached_property #1582

Merged
merged 13 commits into from
Jan 18, 2022
Merged

Replace cached_property with backports.cached_property #1582

merged 13 commits into from
Jan 18, 2022

Conversation

RishiKumarRay
Copy link
Contributor

@RishiKumarRay RishiKumarRay commented Jan 17, 2022

updated dependency to backports.cached_property

Description

Removed older cached_property
installed new backports.cached_property
updated references

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Closes #1517

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Jan 17, 2022

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release replaces cached_property with backports.cached_property to improve
the typing of the library.


Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Rishi Kumar Ray for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@BryceBeagle BryceBeagle linked an issue Jan 17, 2022 that may be closed by this pull request
@BryceBeagle BryceBeagle changed the title Updated dependency Replace cached_property with backports.cached_property Jan 17, 2022
strawberry/field.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1582 (f519938) into main (6d725aa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         130      130           
  Lines        4468     4468           
  Branches      758      758           
=======================================
  Hits         4384     4384           
  Misses         44       44           
  Partials       40       40           

@RishiKumarRay
Copy link
Contributor Author

@BryceBeagle can you please review the PR now

@RishiKumarRay
Copy link
Contributor Author

@patrick91 I have updated your changes. Please do the review

@patrick91
Copy link
Member

@RishiKumarRay thanks! We are missing the RELEASE.md file as suggested by the bot above, can you add it?

There's also a couple of failures related to mypy, can you add a type ignore on strawberry/field.py:135?

@RishiKumarRay
Copy link
Contributor Author

@patrick91 Hi, Patrick I am sorry to say but i have messed up with my repository that i forked and I also don't know how to add this , I was only able to commit your suggestions , I feel i won't be able to do

@patrick91
Copy link
Member

@patrick91 Hi, Patrick I am sorry to say but i have messed up with my repository that i forked and I also don't know how to add this , I was only able to commit your suggestions , I feel i won't be able to do

if you want I can try to help with that on discord :)

@RishiKumarRay
Copy link
Contributor Author

Yeah please let me message you there @patrick91

@patrick91
Copy link
Member

Yeah please let me message you there @patrick91

I think you can message me here -> patrick.py#0235

or you can join the strawberry discord http://strawberry.rocks/discord

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks 😊

@patrick91 patrick91 dismissed BryceBeagle’s stale review January 18, 2022 11:34

code has been updated

@patrick91 patrick91 merged commit a30400d into strawberry-graphql:main Jan 18, 2022
@botberry
Copy link
Member

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cached_property with backports.cached_property
4 participants