Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_executing_* hook to extensions #1400

Merged
merged 9 commits into from
Nov 12, 2021
Merged

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Oct 31, 2021

Description

So that it's possible to override the execution phase. Also add docs and examples on how to use it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jkimbo jkimbo requested a review from a team October 31, 2021 21:12
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #1400 (aed1c24) into main (6f7b5d2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head aed1c24 differs from pull request most recent head 48e7c7d. Consider uploading reports for the commit 48e7c7d to get more accurate results

@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
+ Coverage   98.09%   98.10%   +0.01%     
==========================================
  Files         118      118              
  Lines        4039     4063      +24     
  Branches      579      588       +9     
==========================================
+ Hits         3962     3986      +24     
  Misses         41       41              
  Partials       36       36              

@botberry
Copy link
Member

botberry commented Oct 31, 2021

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Add on_executing_* hooks to extensions to allow you to override the execution phase of a GraphQL operation.


Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Jonathan Kim for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

docs/guides/custom-extensions.md Outdated Show resolved Hide resolved
strawberry/schema/execute.py Outdated Show resolved Hide resolved
tests/schema/extensions/test_extensions.py Outdated Show resolved Hide resolved
tests/schema/extensions/test_extensions.py Outdated Show resolved Hide resolved
tests/schema/extensions/test_extensions.py Outdated Show resolved Hide resolved
docs/guides/custom-extensions.md Outdated Show resolved Hide resolved
@jkimbo jkimbo merged commit 24c0f28 into main Nov 12, 2021
@jkimbo jkimbo deleted the add-executing-step-extensions branch November 12, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: 'Rejecting' Requests in Extensions
5 participants