Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra group for FastAPI #1366

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Add extra group for FastAPI #1366

merged 2 commits into from
Oct 17, 2021

Conversation

patrick91
Copy link
Member

Apparently marking a dependency as optional is not enough, you also need to create an extra group for it

Closes #1365

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1366 (7e5a046) into main (c6be3b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         113      113           
  Lines        3956     3956           
  Branches      568      568           
=======================================
  Hits         3882     3882           
  Misses         40       40           
  Partials       34       34           

@botberry
Copy link
Member

botberry commented Oct 17, 2021

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release adds an extra dependency for FastAPI to prevent
it being downloaded even when not needed.

To install Strawberry with FastAPI support you can do:

pip install 'strawberry-graphql[fastapi]'

Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Patrick Arminio for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@patrick91 patrick91 merged commit 199bfc4 into main Oct 17, 2021
@patrick91 patrick91 deleted the fix/fastapi-extra branch October 17, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing Strawberry 0.84.1 pulls in unnecessary Fastapi and Starlette packages
3 participants