-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename enum exception #1317
Rename enum exception #1317
Conversation
Thanks for adding the Here's a preview of the changelog: This release renames an internal exception from Here's the preview release card for twitter: Here's the tweet text:
|
Codecov Report
@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 98.07% 98.13% +0.06%
==========================================
Files 105 113 +8
Lines 3786 3963 +177
Branches 532 569 +37
==========================================
+ Hits 3713 3889 +176
+ Misses 41 40 -1
- Partials 32 34 +2 |
strawberry/enum.py
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
from strawberry.type import StrawberryType | |||
|
|||
from .exceptions import NotAnEnum | |||
from .exceptions import ObjectIsNotAnEnum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be consistent so maybe you should put the Error
suffix at the end like ObjectIsNotClassError
or if you are not happy with it remove it from both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated :)
2caffd2
to
0d15e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs RELEASE.md
@BryceBeagle I marked this as a patch as the exception is thrown before schema creation, so this is not really a breaking change I'd say ;; |
Update enum's exception to be consistent with
ObjectIsNotClassError