Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to run subscriptions code snippet as it is #1296

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Ability to run subscriptions code snippet as it is #1296

merged 2 commits into from
Oct 4, 2021

Conversation

sighclone
Copy link
Contributor

Allows you to copy the snippet of code from this documentation and run it as is, without code changes. The "testing subscriptions" snippet has been updated for the same.

Description

I have imported the necessary packages and have also created the dependent subscription class. I have also defined schema in order for the code to run as is.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

#1294
*

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Allows you to copy the snippet of code from this documentation and run it as is, without code changes. The "testing subscriptions" snippet has been updated for the same.
Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I've asked for a couple of changes, but it's great overall 😊

docs/operations/testing.md Outdated Show resolved Hide resolved
docs/operations/testing.md Show resolved Hide resolved
docs/operations/testing.md Outdated Show resolved Hide resolved
Created Query class and also made the other requested changes on PR #1296
@sighclone
Copy link
Contributor Author

Done! I've made the requested changes

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you 😊

@patrick91 patrick91 merged commit b4cc757 into strawberry-graphql:main Oct 4, 2021
@botberry
Copy link
Member

botberry commented Oct 4, 2021

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥

@sighclone sighclone deleted the patch-1 branch October 13, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants