Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyerror in selected_fields when a variable is not defined #1249

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Sep 14, 2021

Description

Fix bug with selected_fields and undefined variables

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #1249 (3d6488e) into main (a559299) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   97.63%   97.69%   +0.06%     
==========================================
  Files          88       88              
  Lines        3382     3388       +6     
  Branches      496      498       +2     
==========================================
+ Hits         3302     3310       +8     
+ Misses         44       43       -1     
+ Partials       36       35       -1     

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@botberry
Copy link
Member

botberry commented Sep 14, 2021

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Fixes a bug with the selected_fields property on info when an operation
variable is not defined.

Issue #1248.


Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to @ignormies for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@jkimbo jkimbo merged commit 3765ff4 into main Sep 14, 2021
@jkimbo jkimbo deleted the bugfix/selected-fields-undefined-variable branch September 14, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined variable issue in 0.77.6
3 participants