Fix Pydantic Unions #1231
Merged
Fix Pydantic Unions #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2021 14:18
…ma_fix_unions_pydantic # Conflicts: # tests/experimental/pydantic/test_conversion.py
|
Thanks for adding the Here's a preview of the changelog: Fixes a bug in the Pydantic conversion code around Here's the preview release card for twitter: Here's the tweet text: |
Codecov Report
@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 97.58% 97.56% -0.03%
==========================================
Files 88 88
Lines 3360 3369 +9
Branches 489 493 +4
==========================================
+ Hits 3279 3287 +8
Misses 45 45
- Partials 36 37 +1 |
|
@Matt343 thanks! I'll try to review this over the weekend ^^ |
patrick91
approved these changes
Sep 11, 2021
| @@ -144,6 +144,7 @@ def wrap(cls): | |||
| ) | |||
|
|
|||
| model._strawberry_type = cls # type: ignore | |||
| cls._pydantic_type = model # type: ignore | |||
There was a problem hiding this comment.
this is a patter we want to move away from :)
I think we can keep this for now though, we still need to do some refactoring anyway ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to convert Union types from Pydantic models into Strawberry models, we need to check which branch of the Union we have and proceed with the conversion according to that type definition. I had to add a
_pydantic_typefield to ourStrawberryTypeinstances that are created through the converter so that we can get a reference to the original type of each branch for comparison. This seems a little hacky, but I couldn't think of a better way.This fix only works for Unions of object types, but that should be fine as GraphQL doesn't support other types of unions.
Types of Changes
Issues Fixed or Closed by This PR
Checklist