-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When scrolling down the navbar at top hides automatically reopened #215
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for startling-capybara-2231ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @Aashutoshbro thanks for the PR, what do you think of the menu appearing on the scroll up? It's important imo that we keep the call to actions to important things to the website. Would you be able to add that? |
@pavlenex It would be great if you could tell me which one (CTA) to include as per the PR, I just made some property change to meet the issue. |
@Aashutoshbro entire navbar? check this for context #200 (comment) |
So it's not actually about making nav hide exactly on scroll up, I guess, "I mean yeah, that's the point of the sticky navbar, it's not a bug. It's there so it highlights call to actions clearly."- @pavlenex |
@Aashutoshbro Hide nav bar on scroll down and show it on scroll up, is that possible? |
So it's like enhancement to navbar for clear sticky navbar function can you tell me more about what exactly might me done to go with issue? |
Can it be achieve with this, you can check this out : @pavlenex (Code line 8) Previous one: (Code line 8) Change to: |
If you test these locally and they work, feel free to push them and then we'll have a live preview link build by netlify. Sorry ,not on my pc to test this. |
Works if the above approach is applied: @pavlenex |
Hey @Aashutoshbro just tested https://deploy-preview-215--startling-capybara-2231ea.netlify.app and header is removed on scroll down, but doesn't re-appear on scroll up |
Will try to sort that out |
Issue #200
When scrolling down the navbar at the top should hide automatically