-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Every MG test in a separate action #905
Merged
plebhash
merged 5 commits into
stratum-mining:dev
from
lorbax:every-test-in-a-separate-action
May 20, 2024
Merged
Every MG test in a separate action #905
plebhash
merged 5 commits into
stratum-mining:dev
from
lorbax:every-test-in-a-separate-action
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
lorbax
force-pushed
the
every-test-in-a-separate-action
branch
25 times, most recently
from
May 13, 2024 20:28
e6cd798
to
de39233
Compare
lorbax
force-pushed
the
every-test-in-a-separate-action
branch
from
May 14, 2024 14:34
f180626
to
805a56f
Compare
a sleep time is added for letting all the process close properly
lorbax
force-pushed
the
every-test-in-a-separate-action
branch
from
May 14, 2024 16:06
805a56f
to
04db6a0
Compare
lorbax
changed the title
WIP Every MG test in a separate action
Every MG test in a separate action
May 14, 2024
Closed
do we have an issue to track this? |
plebhash
reviewed
May 16, 2024
test/message-generator/test/bad-pool-config-test/bad-pool-config-test.sh
Show resolved
Hide resolved
plebhash
reviewed
May 16, 2024
test/message-generator/test/interop-jd-translator/interop-jd-translator.sh
Show resolved
Hide resolved
plebhash
reviewed
May 16, 2024
test/message-generator/test/interop-jdc-change-upstream/interop-jdc-change-upstream.sh
Show resolved
Hide resolved
plebhash
reviewed
May 16, 2024
...enerator/test/interop-proxy-with-multi-ups-extended/interop-proxy-with-multi-ups-extended.sh
Show resolved
Hide resolved
plebhash
reviewed
May 16, 2024
test/message-generator/test/interop-proxy-with-multi-ups/interop-proxy-with-multi-ups.sh
Show resolved
Hide resolved
plebhash
reviewed
May 16, 2024
test/message-generator/test/standard-coverage-test/standard-coverage-test.json
Show resolved
Hide resolved
plebhash
reviewed
May 16, 2024
plebhash
approved these changes
May 20, 2024
target directory should be cached (and shared) between action, so that you can reuse most of the already built artifact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AIM of this PR is to split every Message Generator test in a separate GH action
the test
interop-jdc-change-upstream
is excluded from MG action jobs. It refuses to pass even with all the needed applications precompiled. This requires more investigation, possibly spitting this test in smaller tests. There is the possiblity that GH has not enough resources for making it run successfully. Worth noting that this test was excluded from GH actions also before this PR.Now each test is launched by a script which precompiles the binaries that are going to be used. This reduces the risk of test fail due to timeouts.