Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every MG test in a separate action #905

Merged
merged 5 commits into from
May 20, 2024

Conversation

lorbax
Copy link
Collaborator

@lorbax lorbax commented May 10, 2024

The AIM of this PR is to split every Message Generator test in a separate GH action
the test interop-jdc-change-upstream is excluded from MG action jobs. It refuses to pass even with all the needed applications precompiled. This requires more investigation, possibly spitting this test in smaller tests. There is the possiblity that GH has not enough resources for making it run successfully. Worth noting that this test was excluded from GH actions also before this PR.
Now each test is launched by a script which precompiles the binaries that are going to be used. This reduces the risk of test fail due to timeouts.

@lorbax lorbax changed the base branch from main to dev May 10, 2024 20:42
Copy link
Contributor

github-actions bot commented May 10, 2024

🐰Bencher

ReportMon, May 20, 2024 at 16:31:55 UTC
ProjectStratum v2 (SRI)
Branch905/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,898.80 (-0.57%)7,208.32 (95.71%)
client-submit-serialize-deserialize✅ (view plot)7,930.70 (+0.92%)8,209.87 (96.60%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,313.50 (-1.37%)8,730.25 (95.23%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)889.44 (-1.08%)926.19 (96.03%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)688.21 (-1.54%)719.98 (95.59%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)244.69 (-1.93%)259.11 (94.43%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)156.51 (-0.28%)160.26 (97.66%)
client-sv1-get-submit✅ (view plot)6,488.60 (-3.10%)6,971.18 (93.08%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)282.17 (+1.54%)290.70 (97.07%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)779.51 (+3.79%)790.22 (98.64%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)628.42 (+1.81%)639.36 (98.29%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)205.21 (-0.22%)218.65 (93.85%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 10, 2024

🐰Bencher

ReportMon, May 20, 2024 at 16:31:56 UTC
ProjectStratum v2 (SRI)
Branchevery-test-in-a-separate-action
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,095.00 (+0.77%)2,177.31 (96.22%)✅ (view plot)473.00 (+0.32%)484.41 (97.64%)✅ (view plot)735.00 (+0.46%)750.22 (97.97%)✅ (view plot)6.00 (-24.53%)12.11 (49.54%)✅ (view plot)38.00 (+1.72%)39.82 (95.43%)
client_sv2_handle_message_mining✅ (view plot)8,203.00 (-0.08%)8,332.85 (98.44%)✅ (view plot)2,137.00 (+0.30%)2,167.48 (98.59%)✅ (view plot)3,163.00 (+0.42%)3,209.39 (98.55%)✅ (view plot)35.00 (-8.52%)42.38 (82.59%)✅ (view plot)139.00 (-0.08%)141.93 (97.93%)
client_sv2_mining_message_submit_standard✅ (view plot)6,280.00 (-0.10%)6,381.19 (98.41%)✅ (view plot)1,750.00 (+0.02%)1,760.77 (99.39%)✅ (view plot)2,555.00 (+0.09%)2,570.68 (99.39%)✅ (view plot)17.00 (-8.81%)23.39 (72.69%)✅ (view plot)104.00 (-0.01%)106.67 (97.50%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,863.00 (+0.22%)15,076.51 (98.58%)✅ (view plot)4,694.00 (+0.01%)4,704.77 (99.77%)✅ (view plot)6,753.00 (+0.01%)6,770.08 (99.75%)✅ (view plot)47.00 (-2.18%)52.97 (88.73%)✅ (view plot)225.00 (+0.47%)231.01 (97.40%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,594.00 (+0.14%)27,910.18 (98.87%)✅ (view plot)10,545.00 (+0.02%)10,556.95 (99.89%)✅ (view plot)15,339.00 (+0.02%)15,354.67 (99.90%)✅ (view plot)85.00 (-0.45%)91.39 (93.01%)✅ (view plot)338.00 (+0.32%)346.80 (97.46%)
client_sv2_open_channel✅ (view plot)4,561.00 (+1.01%)4,627.06 (98.57%)✅ (view plot)1,461.00 (+0.03%)1,472.06 (99.25%)✅ (view plot)2,151.00 (-0.04%)2,168.40 (99.20%)✅ (view plot)13.00 (+3.54%)15.67 (82.97%)✅ (view plot)67.00 (+1.93%)68.61 (97.66%)
client_sv2_open_channel_serialize✅ (view plot)14,292.00 (+0.16%)14,497.54 (98.58%)✅ (view plot)5,064.00 (+0.01%)5,075.06 (99.78%)✅ (view plot)7,317.00 (-0.00%)7,334.79 (99.76%)✅ (view plot)37.00 (+0.57%)40.76 (90.77%)✅ (view plot)194.00 (+0.33%)199.98 (97.01%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,746.00 (+0.14%)23,074.47 (98.58%)✅ (view plot)7,987.00 (+0.03%)7,999.52 (99.84%)✅ (view plot)11,611.00 (-0.01%)11,631.04 (99.83%)✅ (view plot)78.00 (+4.60%)82.50 (94.54%)✅ (view plot)307.00 (+0.14%)316.13 (97.11%)
client_sv2_setup_connection✅ (view plot)4,733.00 (+0.50%)4,768.64 (99.25%)✅ (view plot)1,502.00 (+0.03%)1,513.06 (99.27%)✅ (view plot)2,278.00 (+0.04%)2,295.60 (99.23%)✅ (view plot)8.00 (-10.74%)12.41 (64.46%)✅ (view plot)69.00 (+1.16%)69.81 (98.84%)
client_sv2_setup_connection_serialize✅ (view plot)16,402.00 (+0.62%)16,490.10 (99.47%)✅ (view plot)5,963.00 (+0.01%)5,974.06 (99.81%)✅ (view plot)8,652.00 (-0.03%)8,672.73 (99.76%)✅ (view plot)45.00 (+0.86%)48.31 (93.15%)✅ (view plot)215.00 (+1.37%)217.45 (98.88%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,634.00 (+0.18%)35,768.77 (99.62%)✅ (view plot)14,814.00 (+0.02%)14,826.52 (99.92%)✅ (view plot)21,749.00 (+0.01%)21,766.36 (99.92%)✅ (view plot)103.00 (-0.18%)117.33 (87.79%)✅ (view plot)382.00 (+0.46%)384.40 (99.38%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 10, 2024

🐰Bencher

ReportMon, May 20, 2024 at 16:31:59 UTC
ProjectStratum v2 (SRI)
Branchevery-test-in-a-separate-action
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,510.00 (+0.86%)8,670.46 (98.15%)✅ (view plot)3,774.00 (+0.91%)3,832.64 (98.47%)✅ (view plot)5,290.00 (+0.91%)5,367.15 (98.56%)✅ (view plot)7.00 (-14.35%)10.16 (68.88%)✅ (view plot)91.00 (+0.99%)93.39 (97.44%)
get_submit✅ (view plot)95,611.00 (+0.06%)96,037.31 (99.56%)✅ (view plot)59,467.00 (+0.02%)59,703.75 (99.60%)✅ (view plot)85,391.00 (+0.02%)85,723.74 (99.61%)✅ (view plot)56.00 (-2.11%)64.92 (86.26%)✅ (view plot)284.00 (+0.42%)287.60 (98.75%)
get_subscribe✅ (view plot)8,081.00 (+1.04%)8,246.12 (98.00%)✅ (view plot)2,869.00 (+1.27%)2,923.93 (98.12%)✅ (view plot)4,006.00 (+1.26%)4,075.75 (98.29%)✅ (view plot)17.00 (-2.27%)21.57 (78.83%)✅ (view plot)114.00 (+0.90%)116.68 (97.71%)
serialize_authorize✅ (view plot)12,229.00 (+0.38%)12,405.41 (98.58%)✅ (view plot)5,345.00 (+0.64%)5,403.64 (98.91%)✅ (view plot)7,454.00 (+0.66%)7,531.03 (98.98%)✅ (view plot)10.00 (-12.72%)13.91 (71.88%)✅ (view plot)135.00 (+0.10%)138.19 (97.69%)
serialize_deserialize_authorize✅ (view plot)24,508.00 (+0.17%)24,653.38 (99.41%)✅ (view plot)9,926.00 (+0.32%)9,992.48 (99.33%)✅ (view plot)13,998.00 (+0.31%)14,094.63 (99.31%)✅ (view plot)37.00 (-1.38%)41.51 (89.13%)✅ (view plot)295.00 (+0.00%)297.43 (99.18%)
serialize_deserialize_handle_authorize✅ (view plot)30,213.00 (+0.18%)30,320.11 (99.65%)✅ (view plot)12,129.00 (+0.28%)12,187.64 (99.52%)✅ (view plot)17,158.00 (+0.26%)17,243.52 (99.50%)✅ (view plot)63.00 (+5.11%)66.03 (95.40%)✅ (view plot)364.00 (-0.04%)366.56 (99.30%)
serialize_deserialize_handle_submit✅ (view plot)126,472.00 (+0.04%)126,930.09 (99.64%)✅ (view plot)73,224.00 (-0.01%)73,534.96 (99.58%)✅ (view plot)104,937.00 (-0.02%)105,382.96 (99.58%)✅ (view plot)128.00 (+3.64%)135.45 (94.50%)✅ (view plot)597.00 (+0.24%)599.26 (99.62%)
serialize_deserialize_handle_subscribe✅ (view plot)27,563.00 (+0.30%)27,622.79 (99.78%)✅ (view plot)9,671.00 (+0.37%)9,725.93 (99.44%)✅ (view plot)13,673.00 (+0.35%)13,751.24 (99.43%)✅ (view plot)69.00 (+4.14%)71.65 (96.30%)✅ (view plot)387.00 (+0.15%)388.89 (99.51%)
serialize_deserialize_submit✅ (view plot)115,069.00 (+0.01%)115,509.06 (99.62%)✅ (view plot)68,001.00 (-0.03%)68,298.24 (99.56%)✅ (view plot)97,549.00 (-0.04%)97,985.14 (99.55%)✅ (view plot)74.00 (+3.83%)78.23 (94.59%)✅ (view plot)490.00 (+0.23%)492.76 (99.44%)
serialize_deserialize_subscribe✅ (view plot)22,948.00 (+0.26%)23,089.29 (99.39%)✅ (view plot)8,223.00 (+0.43%)8,279.25 (99.32%)✅ (view plot)11,578.00 (+0.42%)11,654.48 (99.34%)✅ (view plot)41.00 (+2.22%)44.17 (92.83%)✅ (view plot)319.00 (+0.05%)321.55 (99.21%)
serialize_submit✅ (view plot)99,894.00 (+0.02%)100,333.90 (99.56%)✅ (view plot)61,511.00 (+0.02%)61,752.24 (99.61%)✅ (view plot)88,239.00 (+0.02%)88,576.78 (99.62%)✅ (view plot)56.00 (-3.67%)66.00 (84.85%)✅ (view plot)325.00 (+0.12%)328.27 (99.00%)
serialize_subscribe✅ (view plot)11,376.00 (+0.50%)11,537.85 (98.60%)✅ (view plot)4,216.00 (+0.86%)4,270.93 (98.71%)✅ (view plot)5,866.00 (+0.87%)5,936.03 (98.82%)✅ (view plot)17.00 (-2.82%)21.15 (80.38%)✅ (view plot)155.00 (+0.14%)158.14 (98.01%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 10, 2024

🐰Bencher

ReportMon, May 20, 2024 at 16:32:01 UTC
ProjectStratum v2 (SRI)
Branchevery-test-in-a-separate-action
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.56 (-0.04%)45.29 (98.40%)
client_sv2_handle_message_mining✅ (view plot)74.61 (+0.57%)83.30 (89.56%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.16%)15.01 (97.52%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)248.66 (-6.05%)282.59 (87.99%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)597.61 (+0.51%)625.63 (95.52%)
client_sv2_open_channel✅ (view plot)167.03 (+1.25%)171.01 (97.67%)
client_sv2_open_channel_serialize✅ (view plot)294.99 (+3.70%)297.70 (99.09%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)370.33 (-1.32%)398.42 (92.95%)
client_sv2_setup_connection✅ (view plot)165.69 (+0.72%)175.10 (94.63%)
client_sv2_setup_connection_serialize✅ (view plot)498.25 (+4.79%)502.94 (99.07%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)935.49 (-3.61%)1,043.40 (89.66%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@lorbax lorbax force-pushed the every-test-in-a-separate-action branch 25 times, most recently from e6cd798 to de39233 Compare May 13, 2024 20:28
@lorbax lorbax force-pushed the every-test-in-a-separate-action branch from f180626 to 805a56f Compare May 14, 2024 14:34
@lorbax lorbax force-pushed the every-test-in-a-separate-action branch from 805a56f to 04db6a0 Compare May 14, 2024 16:06
@lorbax lorbax changed the title WIP Every MG test in a separate action Every MG test in a separate action May 14, 2024
@pavlenex pavlenex modified the milestones: 1.0.2, 1.0.1 May 14, 2024
@pavlenex pavlenex linked an issue May 15, 2024 that may be closed by this pull request
@plebhash
Copy link
Collaborator

the test interop-jdc-change-upstream is excluded from MG action jobs

do we have an issue to track this?

@plebhash plebhash merged commit 8ccc4d6 into stratum-mining:dev May 20, 2024
13 checks passed
@Fi3
Copy link
Collaborator

Fi3 commented May 21, 2024

target directory should be cached (and shared) between action, so that you can reuse most of the already built artifact.
I don't see the need to have a shell script for each test, I guess that having only one and passing to it the name of the test will be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

Improve flaky MG tests
4 participants