Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize roles CLI #814

Closed
wants to merge 6 commits into from
Closed

standardize roles CLI #814

wants to merge 6 commits into from

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Mar 22, 2024 •
edited
Loading

close #813
close #456

  • renames *Result and *Error structs to follow a standardized naming convention for all roles
  • replaces toml dependency with config (see Update all toml dependencies to a published version #456)
  • introduces clap for managing CLI
  • introduces a separate args.rs module into all roles for managing CLI args
  • introduces a separate *_config.rs module into all roles for managing role *Config structs

@plebhash plebhash force-pushed the standardize-roles-cli branch from 90572e9 to 6590efe Compare March 22, 2024 19:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

🐰Bencher

ReportFri, March 22, 2024 at 19:33:33 UTC
ProjectStratum v2 (SRI)
Branchstandardize-roles-cli
Testbedsv2
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.390 (-0.06%)45.190 (98.23%)
client_sv2_handle_message_mining✅ (view plot)73.094 (+2.11%)81.539 (89.64%)
client_sv2_mining_message_submit_standard✅ (view plot)14.636 (-0.12%)14.700 (99.56%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)260.790 (-1.80%)281.093 (92.78%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)594.760 (+1.26%)612.287 (97.14%)
client_sv2_open_channel✅ (view plot)164.570 (-0.39%)171.224 (96.11%)
client_sv2_open_channel_serialize✅ (view plot)284.410 (-0.15%)295.861 (96.13%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)371.460 (-1.40%)410.904 (90.40%)
client_sv2_setup_connection✅ (view plot)161.020 (-1.82%)177.534 (90.70%)
client_sv2_setup_connection_serialize✅ (view plot)465.420 (-2.04%)502.024 (92.71%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)958.310 (-2.21%)1055.600 (90.78%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

🐰Bencher

ReportFri, March 22, 2024 at 19:33:31 UTC
ProjectStratum v2 (SRI)
Branchstandardize-roles-cli
Testbedsv2
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2081.000 (+1.98%)2132.395 (97.59%)✅ (view plot)473.000 (+1.04%)484.835 (97.56%)✅ (view plot)731.000 (+0.35%)752.564 (97.13%)✅ (view plot)11.000 (+48.08%)12.728 (86.43%)✅ (view plot)37.000 (+1.57%)38.694 (95.62%)
client_sv2_handle_message_mining✅ (view plot)8257.000 (+1.18%)8310.171 (99.36%)✅ (view plot)2137.000 (+0.89%)2174.334 (98.28%)✅ (view plot)3157.000 (+0.86%)3221.413 (98.00%)✅ (view plot)40.000 (+0.36%)44.809 (89.27%)✅ (view plot)140.000 (+1.42%)141.323 (99.06%)
client_sv2_mining_message_submit_standard✅ (view plot)6296.000 (+0.17%)6429.790 (97.92%)✅ (view plot)1750.000 (+0.08%)1763.280 (99.25%)✅ (view plot)2551.000 (-0.01%)2573.951 (99.11%)✅ (view plot)21.000 (+13.29%)23.991 (87.53%)✅ (view plot)104.000 (-0.03%)107.925 (96.36%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14943.000 (+1.44%)15055.515 (99.25%)✅ (view plot)4694.000 (+0.03%)4707.280 (99.72%)✅ (view plot)6748.000 (-0.08%)6776.253 (99.58%)✅ (view plot)50.000 (+3.47%)53.733 (93.05%)✅ (view plot)227.000 (+2.70%)230.181 (98.62%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27696.000 (+1.09%)27833.836 (99.50%)✅ (view plot)10545.000 (+0.07%)10555.363 (99.90%)✅ (view plot)15336.000 (+0.00%)15357.858 (99.86%)✅ (view plot)85.000 (+1.02%)88.409 (96.14%)✅ (view plot)341.000 (+2.53%)344.986 (98.84%)
client_sv2_open_channel✅ (view plot)4531.000 (+1.34%)4614.818 (98.18%)✅ (view plot)1461.000 (+0.14%)1474.560 (99.08%)✅ (view plot)2151.000 (-0.04%)2173.266 (98.98%)✅ (view plot)14.000 (+20.62%)15.617 (89.65%)✅ (view plot)66.000 (+2.16%)68.270 (96.68%)
client_sv2_open_channel_serialize✅ (view plot)14350.000 (+1.31%)14440.727 (99.37%)✅ (view plot)5064.000 (+0.04%)5077.560 (99.73%)✅ (view plot)7310.000 (-0.09%)7341.078 (99.58%)✅ (view plot)43.000 (+12.31%)44.933 (95.70%)✅ (view plot)195.000 (+2.54%)197.743 (98.61%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22810.000 (+1.20%)22953.832 (99.37%)✅ (view plot)7987.000 (+0.10%)7997.874 (99.86%)✅ (view plot)11610.000 (-0.02%)11637.862 (99.76%)✅ (view plot)77.000 (+6.89%)80.979 (95.09%)✅ (view plot)309.000 (+2.34%)312.885 (98.76%)
client_sv2_setup_connection✅ (view plot)4707.000 (+0.06%)4779.525 (98.48%)✅ (view plot)1502.000 (+0.13%)1515.560 (99.11%)✅ (view plot)2277.000 (+0.14%)2298.800 (99.05%)✅ (view plot)10.000 (-2.78%)14.233 (70.26%)✅ (view plot)68.000 (+0.05%)69.918 (97.26%)
client_sv2_setup_connection_serialize✅ (view plot)16342.000 (+0.80%)16428.461 (99.47%)✅ (view plot)5963.000 (+0.03%)5976.560 (99.77%)✅ (view plot)8652.000 (-0.03%)8679.745 (99.68%)✅ (view plot)47.000 (+5.36%)49.197 (95.53%)✅ (view plot)213.000 (+1.65%)215.570 (98.81%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35650.000 (+0.47%)35725.541 (99.79%)✅ (view plot)14814.000 (+0.05%)14824.874 (99.93%)✅ (view plot)21745.000 (-0.02%)21773.194 (99.87%)✅ (view plot)107.000 (+10.80%)111.736 (95.76%)✅ (view plot)382.000 (+0.89%)384.029 (99.47%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

🐰Bencher

ReportFri, March 22, 2024 at 19:33:30 UTC
ProjectStratum v2 (SRI)
Branch814/merge
Testbedsv1
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6966.800 (+1.10%)7232.273 (96.33%)
client-submit-serialize-deserialize✅ (view plot)7780.500 (-0.04%)8175.277 (95.17%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8334.300 (-0.39%)8754.801 (95.20%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)899.610 (+0.09%)930.107 (96.72%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)701.320 (+0.61%)723.281 (96.96%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)251.260 (+1.14%)256.344 (98.02%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)158.190 (+0.81%)160.995 (98.26%)
client-sv1-get-submit✅ (view plot)6666.400 (+0.33%)6993.408 (95.32%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)275.360 (-1.82%)295.257 (93.26%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)744.250 (-0.02%)769.272 (96.75%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)625.910 (+1.85%)637.808 (98.13%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)208.390 (-0.44%)226.951 (91.82%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

🐰Bencher

ReportFri, March 22, 2024 at 19:33:32 UTC
ProjectStratum v2 (SRI)
Branchstandardize-roles-cli
Testbedsv1
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8440.000 (-0.08%)8496.616 (99.33%)✅ (view plot)3746.000 (-0.07%)3766.138 (99.47%)✅ (view plot)5250.000 (-0.10%)5285.536 (99.33%)✅ (view plot)8.000 (+6.67%)9.913 (80.71%)✅ (view plot)90.000 (-0.12%)91.440 (98.43%)
get_submit✅ (view plot)95537.000 (-0.00%)95601.657 (99.93%)✅ (view plot)59439.000 (-0.01%)59503.287 (99.89%)✅ (view plot)85352.000 (-0.02%)85467.243 (99.87%)✅ (view plot)56.000 (+3.16%)58.821 (95.20%)✅ (view plot)283.000 (+0.06%)284.824 (99.36%)
get_subscribe✅ (view plot)8003.000 (+0.10%)8060.367 (99.29%)✅ (view plot)2841.000 (-0.03%)2846.422 (99.81%)✅ (view plot)3968.000 (-0.05%)3979.677 (99.71%)✅ (view plot)16.000 (+3.23%)18.887 (84.71%)✅ (view plot)113.000 (+0.19%)114.550 (98.65%)
serialize_authorize✅ (view plot)12159.000 (-0.26%)12318.751 (98.70%)✅ (view plot)5317.000 (-0.05%)5337.138 (99.62%)✅ (view plot)7414.000 (-0.06%)7446.355 (99.57%)✅ (view plot)11.000 (+1.65%)13.059 (84.23%)✅ (view plot)134.000 (-0.61%)137.876 (97.19%)
serialize_deserialize_authorize✅ (view plot)24476.000 (-0.04%)24565.576 (99.64%)✅ (view plot)9898.000 (-0.06%)9938.276 (99.59%)✅ (view plot)13956.000 (-0.08%)14029.673 (99.47%)✅ (view plot)39.000 (+4.10%)41.602 (93.75%)✅ (view plot)295.000 (-0.07%)296.978 (99.33%)
serialize_deserialize_handle_authorize✅ (view plot)30187.000 (+0.04%)30251.405 (99.79%)✅ (view plot)12101.000 (-0.02%)12121.138 (99.83%)✅ (view plot)17122.000 (-0.03%)17159.627 (99.78%)✅ (view plot)58.000 (-0.06%)62.051 (93.47%)✅ (view plot)365.000 (+0.15%)366.876 (99.49%)
serialize_deserialize_handle_submit✅ (view plot)126430.000 (+0.00%)126487.863 (99.95%)✅ (view plot)73224.000 (-0.01%)73288.287 (99.91%)✅ (view plot)104940.000 (-0.02%)105059.392 (99.89%)✅ (view plot)126.000 (+4.97%)130.630 (96.46%)✅ (view plot)596.000 (-0.02%)598.438 (99.59%)
serialize_deserialize_handle_subscribe✅ (view plot)27519.000 (+0.11%)27563.644 (99.84%)✅ (view plot)9643.000 (-0.01%)9648.422 (99.94%)✅ (view plot)13634.000 (-0.04%)13650.633 (99.88%)✅ (view plot)68.000 (+5.08%)70.676 (96.21%)✅ (view plot)387.000 (+0.15%)388.766 (99.55%)
serialize_deserialize_submit✅ (view plot)115019.000 (-0.03%)115188.515 (99.85%)✅ (view plot)68001.000 (-0.03%)68129.575 (99.81%)✅ (view plot)97554.000 (-0.03%)97777.278 (99.77%)✅ (view plot)70.000 (+2.14%)73.058 (95.81%)✅ (view plot)489.000 (-0.03%)491.031 (99.59%)
serialize_deserialize_subscribe✅ (view plot)22904.000 (+0.01%)22943.611 (99.83%)✅ (view plot)8195.000 (-0.02%)8205.844 (99.87%)✅ (view plot)11539.000 (-0.03%)11561.605 (99.80%)✅ (view plot)40.000 (+1.54%)44.530 (89.83%)✅ (view plot)319.000 (+0.03%)320.225 (99.62%)
serialize_submit✅ (view plot)99820.000 (-0.03%)99988.835 (99.83%)✅ (view plot)61483.000 (-0.01%)61547.287 (99.90%)✅ (view plot)88200.000 (-0.02%)88310.673 (99.87%)✅ (view plot)56.000 (+2.22%)58.015 (96.53%)✅ (view plot)324.000 (-0.17%)326.805 (99.14%)
serialize_subscribe✅ (view plot)11298.000 (-0.16%)11429.238 (98.85%)✅ (view plot)4188.000 (-0.02%)4193.422 (99.87%)✅ (view plot)5828.000 (-0.02%)5835.601 (99.87%)✅ (view plot)16.000 (+0.67%)18.557 (86.22%)✅ (view plot)154.000 (-0.32%)157.632 (97.70%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash force-pushed the standardize-roles-cli branch 3 times, most recently from 22d7e25 to bb7f2bc Compare March 22, 2024 19:28
This was referenced Mar 26, 2024
Closed
Merged
@plebhash plebhash changed the base branch from main to dev March 28, 2024 22:17
@plebhash plebhash force-pushed the standardize-roles-cli branch from 1df27cb to cb013e3 Compare March 28, 2024 22:23
@plebhash plebhash marked this pull request as draft March 29, 2024 13:18
@plebhash plebhash force-pushed the standardize-roles-cli branch from edc6f84 to a7f746f Compare March 29, 2024 14:54
@plebhash plebhash changed the base branch from dev to main March 29, 2024 14:55
@plebhash plebhash changed the base branch from main to dev March 29, 2024 14:55
@plebhash plebhash mentioned this pull request Mar 29, 2024
Closed
@plebhash plebhash force-pushed the standardize-roles-cli branch 3 times, most recently from 6b66e7a to a3d1aea Compare April 9, 2024 15:08
@plebhash plebhash force-pushed the standardize-roles-cli branch from a3d1aea to 94103dc Compare April 9, 2024 15:08
@rockcoolsaint
Copy link
Contributor

@plebhash I reviewed this PR to the best of my skills and seems a lot of ground has been covered already in terms of the standardization of the roles CLI
Is there any other areas pending that you think needs some attention?

@plebhash plebhash force-pushed the standardize-roles-cli branch from c060358 to dc1cc1a Compare April 15, 2024 22:13
@plebhash plebhash marked this pull request as ready for review April 16, 2024 00:40
@plebhash
Copy link
Collaborator Author

we agreed to close this PR and replace it with a conversation over Github Discussions so we can agree on the conceptual direction for this refactor

@plebhash plebhash closed this Apr 16, 2024
This was referenced May 26, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

standardize roles CLI
2 participants
@plebhash @rockcoolsaint