[TSVB] Allow string fields on value count aggregation (elastic#79267)

* [TSVB] Enable string fields for value count aggregation * fix test title * Allow all field types for value count aggregation Co-authored-by: Kibana Machine <[email protected]>
stratoula · Oct 6, 2020 · 5d05719 · 5d05719
1 parent 649536c
commit 5d05719
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/..._type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js b/..._type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js
@@ -25,6 +25,7 @@ export function getSupportedFieldsByMetricType(type) {
     case METRIC_TYPES.CARDINALITY:
       return Object.values(KBN_FIELD_TYPES).filter((t) => t !== KBN_FIELD_TYPES.HISTOGRAM);
     case METRIC_TYPES.VALUE_COUNT:
+      return Object.values(KBN_FIELD_TYPES);
     case METRIC_TYPES.AVERAGE:
     case METRIC_TYPES.SUM:
       return [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM];

diff --git a/..._timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js b/..._timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js
@@ -18,18 +18,23 @@
  */
 
 import { getSupportedFieldsByMetricType } from './get_supported_fields_by_metric_type';
+import { KBN_FIELD_TYPES } from '../../../../../../plugins/data/public';
 
 describe('getSupportedFieldsByMetricType', () => {
   const shouldHaveHistogramAndNumbers = (type) =>
     it(`should return numbers and histogram for ${type}`, () => {
       expect(getSupportedFieldsByMetricType(type)).toEqual(['number', 'histogram']);
     });
+  const shouldSupportAllFieldTypes = (type) =>
+    it(`should return all field types for ${type}`, () => {
+      expect(getSupportedFieldsByMetricType(type)).toEqual(Object.values(KBN_FIELD_TYPES));
+    });
   const shouldHaveOnlyNumbers = (type) =>
     it(`should return only numbers for ${type}`, () => {
       expect(getSupportedFieldsByMetricType(type)).toEqual(['number']);
     });
 
-  shouldHaveHistogramAndNumbers('value_count');
+  shouldSupportAllFieldTypes('value_count');
   shouldHaveHistogramAndNumbers('avg');
   shouldHaveHistogramAndNumbers('sum');