Snapshot support #1100
Snapshot support #1100
Conversation
|
Expect test failures |
|
Expect all tests to pass |
mulkieran
force-pushed
the
snapshot-support
branch
from
187876b
to
6cb0a24
Compare
|
Really this time... |
mulkieran
force-pushed
the
snapshot-support
branch
from
6cb0a24
to
0a1f79b
Compare
|
/packit build |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
mulkieran
force-pushed
the
snapshot-support
branch
from
0a1f79b
to
62e6922
Compare
There was a problem hiding this comment.
Overall this looks good. The one thing I noticed in the PR is that we seem to create a new error for every error from the CLI when the D-Bus API returns an Identity result. Is this to specifically tie a good error message to each of these cases? Is there an advantage to not using the same error with different error messages as input? This is unrelated to the PR, but more something I noticed while reviewing this.
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Just return the engine error if origin not set. When trying to cancel a revert, and the revert has not been scheduled because the filesystem has no origin, better to reject the cancel action because of the missing origin, rather than because the merge status will not be changed. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]> (cherry picked from commit 39c87a8)
The revised text for the "Snapshot origin" field now looks like this:
Snapshot origin
If this filesystem is a snapshot, its origin. If the filesystem is
a snapshot, whether or not it is scheduled to replace its origin
next time the pool is started.
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
snapshot-support
branch
2 times, most recently
from
3a9e88e
to
fae582b
Compare
I think you're correct, that class inheritance tree looks unnecessarily bushy. We can prune it this autumn. |
|
Expecting tests to pass now... |
Related #1085