Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata #1023

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Metadata #1023

merged 4 commits into from
Jul 22, 2024

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran
Copy link
Member Author

Expect some pool listing tests to fail...

@mulkieran
Copy link
Member Author

should succeed w/ redirect

@bgurney-rh
Copy link
Member

/packit build

@mulkieran mulkieran force-pushed the metadata branch 3 times, most recently from 085b922 to a70131d Compare March 29, 2024 18:56
To make the functionality available when starting a pool.

Signed-off-by: mulhern <[email protected]>
@mulkieran
Copy link
Member Author

/packit build

Display information about metadata version.  Display Le in list view if
legacy metadata version. Display the version number in the detail view.

Alter display for stopped pools to take metadata version into account.

Display encryption info differently for metadata v2.
For stopped pools only:
* In Detail view, drop entries for KeyDescription and Clevis.
* In list view, always report N/A for those fields.

Use pool feature information in StoppedPools.  This information can be used to
modify how the StoppedPools property components are interpreted.

Capitalization change: ^unencrypted^<UNENCRYPTED>:

Make detail view for legacy stopped pools like that for new pools>

Make detail view for started and stopped pools similar. Particularly, if pool
is not encrypted, do not list encryption-related information.

Print UUID before Name in Stopped pool detail.

Signed-off-by: mulhern <[email protected]>
@mulkieran
Copy link
Member Author

/packit build

Copy link
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing I don't think I have any problems with the code, just one note on documentation that could be a little bit clearer.

docs/stratis.txt Outdated
encrypted. If an unlock method of any is specified the pool will be
unlocked with any facility available that allows the pool to be unlocked.
If --keyfile-path or --capture-key is specified, then the pool will use
only the passphrase and method specified, so that the pool will not be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "and the keyslot corresponding to the method specified"

@mulkieran mulkieran requested a review from jbaublitz July 22, 2024 14:22
@mulkieran
Copy link
Member Author

@jbaublitz Ok. I've modified the man page to try to make the pool start rules clearer. Let me know what you think.

@mulkieran mulkieran marked this pull request as ready for review July 22, 2024 17:55
@mulkieran
Copy link
Member Author

/packit build

@mulkieran mulkieran merged commit e53aede into stratis-storage:master Jul 22, 2024
13 checks passed
@mulkieran mulkieran deleted the metadata branch July 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants