-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata #1023
Metadata #1023
Conversation
Expect some pool listing tests to fail... |
should succeed w/ redirect |
/packit build |
085b922
to
a70131d
Compare
To make the functionality available when starting a pool. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
76ec3b9
to
8d21631
Compare
/packit build |
Display information about metadata version. Display Le in list view if legacy metadata version. Display the version number in the detail view. Alter display for stopped pools to take metadata version into account. Display encryption info differently for metadata v2. For stopped pools only: * In Detail view, drop entries for KeyDescription and Clevis. * In list view, always report N/A for those fields. Use pool feature information in StoppedPools. This information can be used to modify how the StoppedPools property components are interpreted. Capitalization change: ^unencrypted^<UNENCRYPTED>: Make detail view for legacy stopped pools like that for new pools> Make detail view for started and stopped pools similar. Particularly, if pool is not encrypted, do not list encryption-related information. Print UUID before Name in Stopped pool detail. Signed-off-by: mulhern <[email protected]>
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing I don't think I have any problems with the code, just one note on documentation that could be a little bit clearer.
docs/stratis.txt
Outdated
encrypted. If an unlock method of any is specified the pool will be | ||
unlocked with any facility available that allows the pool to be unlocked. | ||
If --keyfile-path or --capture-key is specified, then the pool will use | ||
only the passphrase and method specified, so that the pool will not be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "and the keyslot corresponding to the method specified"
@jbaublitz Ok. I've modified the man page to try to make the pool start rules clearer. Let me know what you think. |
Signed-off-by: mulhern <[email protected]>
/packit build |
No description provided.