Packit improvements #1022
Merged
Packit improvements #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we end up w/ some files that we do not need, but the preparation steps are simpler and more consistent. Signed-off-by: mulhern <[email protected]>
Occasionally packit testing may generate these and it would be good if git clean would remove them. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
packit-git
branch
from
0de1347
to
2aa00fe
Compare
|
/packit build |
We prefer to update the version Signed-off-by: mulhern <[email protected]>
If we don't, there may be an unsatisfied build problem. stratis-cli checks internally that it is running against a high enough version. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
packit-git
branch
from
78b88ec
to
f705515
Compare
Have create_artifacts.py print the stratis-cli artifact Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
packit-git
branch
from
f705515
to
3806916
Compare
|
/packit build |
4 similar comments
|
/packit build |
|
/packit build |
|
/packit build |
|
/packit build |
|
/packit build |
1 similar comment
|
/packit build |
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
packit-git
branch
from
c07c796
to
dd2008b
Compare
|
/packit build |
1 similar comment
|
/packit build |
bgurney-rh
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related stratis-storage/project#309