Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model-mommy req #44

Merged
merged 2 commits into from
Mar 16, 2017
Merged

Update model-mommy req #44

merged 2 commits into from
Mar 16, 2017

Conversation

orf
Copy link
Contributor

@orf orf commented Mar 15, 2017

Is there any reason it's pinned to 1.2.6? 1.3.2 is the latest I think, and this library ends up forcing us to use 1.2.6 :(

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #44   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         674    674           
=====================================
  Hits          674    674

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09ec76...fbb50d2. Read the comment docs.

@stphivos
Copy link
Owner

Hey sorry about that!

I'm looking into the Travis build errors of the PR to be able to use model_mommy 1.3.2.

Also, since v1.3.2 is not backwards compatible with v1.2.6, it would be best to add support for a version range like we did for Django, so something like: model_mommy>=1.2.6,<=1.3.99, so it doesn't force it on others too.

@stphivos stphivos merged commit fbb50d2 into stphivos:master Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants