Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix Clang warnings #91

Merged
merged 4 commits into from
Feb 5, 2020
Merged

General: Fix Clang warnings #91

merged 4 commits into from
Feb 5, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Feb 5, 2020

Some of the recent test coverage improvements result in warnings emitted by the Clang compiler. Although none of them causes potential harm, they still need to be addressed. Fix them to allow for clean Clang builds.

@stotko stotko added the bug label Feb 5, 2020
@stotko stotko added this to the 1.3.0 milestone Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #91 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          27       27           
  Lines        1611     1611           
=======================================
  Hits         1576     1576           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec8d22...650cdf2. Read the comment docs.

@stotko stotko merged commit 1cfd3d3 into master Feb 5, 2020
@stotko stotko deleted the clang_warning_fixes branch February 5, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant