Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: Drop workaround for to_address #431

Merged
merged 1 commit into from
Aug 27, 2024
Merged

memory: Drop workaround for to_address #431

merged 1 commit into from
Aug 27, 2024

Conversation

stotko
Copy link
Owner

@stotko stotko commented Aug 27, 2024

Due to the recently bumped requirements for CUDA, the workaround for to_address in memory to avoid a compiler warning is no longer needed. Drop this pre C++17 SFINAE version in favor of the simpler version leveraging constexpr syntax.

@stotko stotko added this to the 2.0.0 milestone Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (a5ea998) to head (0aec15d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   97.38%   97.50%   +0.11%     
==========================================
  Files          32       32              
  Lines        2524     2524              
==========================================
+ Hits         2458     2461       +3     
+ Misses         66       63       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit 3333da6 into master Aug 27, 2024
61 checks passed
@stotko stotko deleted the memory_to_address branch August 27, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant