Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Make installable package relocatable #180

Merged
merged 1 commit into from
May 29, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented May 29, 2020

When installing stdgpu to a certain location, the package currently contains absolute paths which hard-code the installation destination. However, this prohibits moving the package to another location and forces a re-installation with the modified path. Make the package relocatable by removing all absolute paths to reduce this installation burden for users.

@stotko stotko added this to the 1.3.0 milestone May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #180 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   97.81%   97.76%   -0.06%     
==========================================
  Files          28       28              
  Lines        1833     1833              
==========================================
- Hits         1793     1792       -1     
- Misses         40       41       +1     
Impacted Files Coverage Δ
src/stdgpu/impl/unordered_base_detail.cuh 96.25% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd45e4...dea2968. Read the comment docs.

@stotko stotko merged commit 4598872 into master May 29, 2020
@stotko stotko deleted the cmake_relocatable_install branch May 29, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant