limits: Suppress long double device code warning with MSVC #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 28 28
Lines 1833 1833
=======================================
Hits 1793 1793
Misses 40 40
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The probably last long-standing warning is thrown by MSVC with the CUDA backend enabled stating that long double will be treated as double in device code. This is caused by MSVC's implementation of
HUGE_VALLwhich is expands to(long double)INFINITY. Suppress this warning by usingHUGE_VALfor MSVC instead which avoids explicitly casting tolong double.