Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples,src,test: Fix readability-magic-numbers warnings #141

Merged
merged 4 commits into from
Apr 19, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 19, 2020

In addition the recent warning fixes (see #140), there are still some warnings left. Fix these readability-magic-numbers warnings to ensure clean builds under clang-tidy-8.

@stotko stotko added the bug label Apr 19, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 19, 2020
@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files          28       28           
  Lines        1698     1698           
=======================================
  Hits         1658     1658           
  Misses         40       40           
Impacted Files Coverage Δ
src/stdgpu/impl/limits_detail.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedd459...59f109d. Read the comment docs.

@stotko stotko merged commit ae925d8 into master Apr 19, 2020
@stotko stotko deleted the readability_magic_numbers branch April 19, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant