Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: Fix readability-else-after-return warnings #133

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 16, 2020

else statements after a return in the preceding if clause seem intuitive at first glance since they follow natural language. However, the else statement is superfluous from a technical point of view. Follow clang-tidy recommendations and drop these statements.

@stotko stotko added the bug label Apr 16, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          28       28           
  Lines        1694     1694           
=======================================
  Hits         1654     1654           
  Misses         40       40           
Impacted Files Coverage Δ
src/stdgpu/impl/deque_detail.cuh 93.56% <100.00%> (ø)
src/stdgpu/impl/unordered_base_detail.cuh 96.49% <100.00%> (ø)
src/stdgpu/impl/vector_detail.cuh 93.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f15ec7...fd9fa64. Read the comment docs.

@stotko stotko merged commit 69aa426 into master Apr 16, 2020
@stotko stotko deleted the warnings_else_after_return branch April 16, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant