Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of stdgpu::unordered_map #13

Closed
wants to merge 1 commit into from

Conversation

ykkawana
Copy link

It took me a bit while to grab how to use unordered_map, so I made this simple example code.

@ykkawana ykkawana force-pushed the unordered_map_example branch 2 times, most recently from 3e9342d to 28d30fb Compare October 29, 2019 11:54
@stotko
Copy link
Owner

stotko commented Oct 29, 2019

Thank you. I have a few remarks:

  • container_kernel.cu contains a similar example on how to use the stdgpu::unordered_set within a kernel.
  • There is also a similar code snippet in the examples section of the README.
  • In your example, there are many calls to cudaMalloc, cudaFree and cudaMemcpy. I would prefer stdgpu's function, i.e. createDeviceArray etc.

Therefore, I think it is a good idea to add an explicit example for stdgpu::unordered_map. Please adapt it to match the other examples and the general coding style of the library.

@stotko
Copy link
Owner

stotko commented May 22, 2020

More examples have been added by #173. In addition, much effort has been much put into improving the documentation, so I think it should be easier now for users to get an idea of the library.

If you still have suggestions on how to improve certain aspects of the library, please open an issue. Thanks again for your contribution. Closing.

@stotko stotko closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants