Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranges: Fix compilation error with select functor #125

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 6, 2020

In #122, the API of the ranges module has been extended. However, on older compilers such as NVCC 10.0, this causes compilation errors where the default constructor of the internal select functor is missing. Fix this issue by adding the respective default constructor.

@stotko stotko added the bug label Apr 6, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #125 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          28       28           
  Lines        1685     1685           
=======================================
  Hits         1650     1650           
  Misses         35       35           
Impacted Files Coverage Δ
src/stdgpu/impl/ranges_detail.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 770c1a9...5ffbafb. Read the comment docs.

@stotko stotko merged commit bec6f08 into master Apr 6, 2020
@stotko stotko deleted the ranges_select_fix branch April 6, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant