Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Fixed compile error (issue #45) - upgraded nan to >= 2.14.0 and fixed… #1

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fixed compile error (issue #45) - upgraded nan to >= 2.14.0 and fixed… #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "build/Release/fontmanager",
"types": "index.d.ts",
"dependencies": {
"nan": ">=2.10.0"
"nan": ">=2.14.0"
},
"devDependencies": {
"mocha": "*"
Expand Down
2 changes: 1 addition & 1 deletion src/FontDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ struct FontDescriptor {
MaybeLocal<Value> value = Nan::Get(obj, Nan::New<String>(name).ToLocalChecked());

if (!value.IsEmpty() && value.ToLocalChecked()->IsBoolean()) {
return value.ToLocalChecked()->BooleanValue(Nan::GetCurrentContext()).FromJust();
return value.ToLocalChecked()->BooleanValue((Nan::GetCurrentContext())->GetIsolate());
}

return false;
Expand Down