This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Enhance Security by Adding Owner Restriction to Permissions #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoHChen
reviewed
Feb 17, 2024
kingster-will
force-pushed
the
fix-access
branch
from
5dccf7b to
8fd42ef
Compare
LeoHChen
approved these changes
Feb 17, 2024
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
…tocol#104) * initial impl * check ipAccount Owner * add more comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces an enhancement to AccessControl by appending an [ipAccountOwner] field to the existing permission record. This change aims to mitigate the risks associated with the delegation of permissions, particularly in scenarios where the ipAccount might be transferred to a new owner, potentially leading to malicious misuse.
Changes
The permission record has been updated to include an [ipAccountOwner] field. This ensures that a permission is considered valid only if the ipAccount is still owned by the specified [ipAccountOwner].
Test Coverage
The PR includes comprehensive tests covering both positive and negative scenarios to ensure the robustness of the new permission field.