Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Commit

Permalink
style: linting
Browse files Browse the repository at this point in the history
  • Loading branch information
jdubpark committed Feb 17, 2024
1 parent fd4d871 commit 8163d37
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion contracts/interfaces/modules/dispute/IDisputeModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,4 @@ interface IDisputeModule {
/// @notice returns true if the ipId is tagged with any tag (meaning at least one dispute went through)
/// @param _ipId The ipId
function isIpTagged(address _ipId) external view returns (bool);

}
4 changes: 2 additions & 2 deletions contracts/modules/dispute-module/DisputeModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,15 @@ contract DisputeModule is IDisputeModule, BaseModule, Governable, ReentrancyGuar
Dispute memory dispute = disputes[_disputeId];

if (msg.sender != dispute.disputeInitiator) revert Errors.DisputeModule__NotDisputeInitiator();
if (dispute.currentTag == IN_DISPUTE || dispute.currentTag == bytes32(0)) revert Errors.DisputeModule__NotAbleToResolve();
if (dispute.currentTag == IN_DISPUTE || dispute.currentTag == bytes32(0))
revert Errors.DisputeModule__NotAbleToResolve();

successfulDisputesPerIp[dispute.targetIpId]--;
disputes[_disputeId].currentTag = bytes32(0);

emit DisputeResolved(_disputeId);
}


/// @notice returns true if the ipId is tagged with any tag (meaning at least one dispute went through)
/// @param _ipId The ipId
function isIpTagged(address _ipId) external view returns (bool) {
Expand Down
4 changes: 3 additions & 1 deletion contracts/registries/LicenseRegistry.sol
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ contract LicenseRegistry is ILicenseRegistry, ERC1155, Governable {
// TODO: Safeguard mechanism to make sure the attributes added by PFM do NOT overlap with the common traits
// defined above. Currently, we add the common license attributes after adding the PFM attributes to override.
// But OpenSea might take the value of the first duplicate.
json = string(abi.encodePacked(json, IPolicyFrameworkManager(pol.policyFramework).policyToJson(pol.frameworkData)));
json = string(
abi.encodePacked(json, IPolicyFrameworkManager(pol.policyFramework).policyToJson(pol.frameworkData))
);

// append the common license attributes
json = string(
Expand Down
1 change: 0 additions & 1 deletion test/foundry/mocks/module/MockDisputeModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -126,5 +126,4 @@ contract MockDisputeModule is BaseModule, IDisputeModule {
function isIpTagged(address) external pure returns (bool) {
return false;
}

}
1 change: 0 additions & 1 deletion test/foundry/modules/dispute/DisputeModule.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ contract DisputeModuleTest is BaseTest {
vm.startPrank(ipAccount1);
vm.expectRevert(Errors.DisputeModule__NotAbleToResolve.selector);
disputeModule.resolveDispute(1);

}

function test_DisputeModule_resolveDispute() public {
Expand Down
1 change: 0 additions & 1 deletion test/foundry/modules/licensing/LicensingModule.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { Errors } from "contracts/lib/Errors.sol";
import { Licensing } from "contracts/lib/Licensing.sol";
import { RegisterUMLPolicyParams } from "contracts/interfaces/modules/licensing/IUMLPolicyFrameworkManager.sol";
import { UMLPolicyFrameworkManager, UMLPolicy } from "contracts/modules/licensing/UMLPolicyFrameworkManager.sol";
import { LicenseRegistry } from "contracts/registries/LicenseRegistry.sol";

// test
// solhint-disable-next-line max-line-length
Expand Down

0 comments on commit 8163d37

Please sign in to comment.