Fix initial bottom panel size #6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dynamic to the screen size
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-mortal94-fix-initial-panel-size.storybook.now.sh |
ndelangen
requested changes
May 19, 2019
| @@ -282,7 +282,7 @@ class Layout extends Component { | |||
| resizerPanel: | |||
| resizerPanel || | |||
| (options.panelPosition === 'bottom' | |||
| ? { x: 0, y: bounds.height - 400 } | |||
| ? { x: 0, y: bounds.height * 0.6 } | |||
There was a problem hiding this comment.
It would be nice to round this to a whole number, to not get inconsistencies
|
Thanks @mortal94 this is great, one small remark, then good to merge IMHO |
Thanks @ndelangen ! i've pushed the requested changes. |
ndelangen
approved these changes
May 19, 2019
|
@mortal94 yes this will be released in beta.2 after it gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The initial bottom panel size on small screens was too big
What I did
Changed the initial value of the bottom panel size to be dynamic to the screen.