Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial bottom panel size #6822

Merged
merged 4 commits into from
May 21, 2019
Merged

Fix initial bottom panel size #6822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df85d56
the initial panel size when the position is at the bottom will now be…
mortal94 May 19, 2019
6e53861
updated snapshot
mortal94 May 19, 2019
59b35ee
rounded the calculation result
mortal94 May 19, 2019
5c23c76
Merge branch 'next' into pr/mortal94/6822
ndelangen May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/ui/src/components/layout/__snapshots__/layout.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ exports[`Storyshots UI|Layout/Desktop bottom Panel 1`] = `
/>
<div
class="react-draggable emotion-1"
style="touch-action:none;left:210px;width:804px;margin-top:-10px;transform:translate(0px,368px)"
style="touch-action:none;left:210px;width:804px;margin-top:-10px;transform:translate(0px,461px)"
/>
<div
class="emotion-3"
Expand Down Expand Up @@ -259,7 +259,7 @@ exports[`Storyshots UI|Layout/Desktop bottom Panel 1`] = `
>
<div
class="emotion-5"
style="height:358px;left:0;top:0;width:804px"
style="height:451px;left:0;top:0;width:804px"
>
<div
class="emotion-4"
Expand All @@ -277,7 +277,7 @@ exports[`Storyshots UI|Layout/Desktop bottom Panel 1`] = `
"animate": true,
"isFullscreen": false,
"position": {
"height": 358,
"height": 451,
"left": 0,
"top": 0,
"width": 804
Expand All @@ -289,7 +289,7 @@ exports[`Storyshots UI|Layout/Desktop bottom Panel 1`] = `
</div>
<div
class="emotion-7"
style="height:390px;left:0;top:358px;width:804px"
style="height:297px;left:0;top:451px;width:804px"
>
<div
class="emotion-6"
Expand All @@ -307,9 +307,9 @@ exports[`Storyshots UI|Layout/Desktop bottom Panel 1`] = `
"align": "bottom",
"hidden": false,
"position": {
"height": 390,
"height": 297,
"left": 0,
"top": 358,
"top": 451,
"width": 804
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/src/components/layout/container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ class Layout extends Component {
resizerPanel:
resizerPanel ||
(options.panelPosition === 'bottom'
? { x: 0, y: bounds.height - 400 }
? { x: 0, y: Math.round(bounds.height * 0.6) }
: { x: bounds.width - 400, y: 0 }),
};
}
Expand Down