Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cra-config): use node-logger instead of console #6245

Merged
merged 1 commit into from
Mar 23, 2019
Merged

fix(cra-config): use node-logger instead of console #6245

merged 1 commit into from
Mar 23, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 23, 2019

@Armanio Armanio added patch:yes Bugfix & documentation PR that need to be picked to main branch cra Prioritize create-react-app compatibility cleanup Minor cleanup style change that won't show up in release changelog labels Mar 23, 2019
shilman
shilman approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@shilman shilman merged commit 8a9d35a into storybookjs:next Mar 23, 2019
@Armanio Armanio deleted the fix/cra_lint branch March 23, 2019 14:31
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 23, 2019
shilman added a commit that referenced this pull request Mar 23, 2019
@shilman
Merge pull request #6245 from Armanio/fix/cra_lint
3ffa55d 
fix(cra-config): use node-logger instead of console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
cleanup Minor cleanup style change that won't show up in release changelog cra Prioritize create-react-app compatibility patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Armanio @shilman