Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cra-config): use node-logger instead of console #6245

Merged
merged 1 commit into from
Mar 23, 2019
+2 −1
Merged

fix(cra-config): use node-logger instead of console #6245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/react/src/server/cra-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import path from 'path';
import semver from 'semver';
import MiniCssExtractPlugin from 'mini-css-extract-plugin';
import { normalizeCondition } from 'webpack/lib/RuleSet';
import { logger } from '@storybook/node-logger';

const cssExtensions = ['.css', '.scss', '.sass'];
const cssModuleExtensions = ['.module.css', '.module.scss', '.module.sass'];
Expand Down Expand Up @@ -42,7 +43,7 @@ export function getReactScriptsPath({ noCache } = {}) {
}
}
} catch (e) {
console.warn('Error occured during react-scripts package path resolving.', e);
logger.warn(`Error occured during react-scripts package path resolving: ${e}`);
}

reactScriptsPath = path.join(reactScriptsScriptPath, '../..');
Expand Down