Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5597 toolbar separators #5711

Merged
merged 8 commits into from
Feb 23, 2019
Merged

5597 toolbar separators #5711

merged 8 commits into from
Feb 23, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented Feb 21, 2019

Issue: #5597

What I did

  • Removed toolbar separators from being displayed between each icon
  • Did some minor cleanup

How to test

See changes in Chromatic and approve

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #5711 into next will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next   #5711      +/-   ##
=========================================
+ Coverage   33.28%   33.3%   +0.02%     
=========================================
  Files         648     648              
  Lines        9371    9373       +2     
  Branches     1355    1331      -24     
=========================================
+ Hits         3119    3122       +3     
+ Misses       5637    5636       -1     
  Partials      615     615
Impacted Files Coverage Δ
lib/components/src/bar/separator.js 0% <ø> (ø) ⬆️
lib/components/src/bar/bar.js 100% <ø> (ø) ⬆️
lib/ui/src/components/preview/preview.js 87.93% <100%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66cc7fd...e2e6f78. Read the comment docs.

@shilman shilman merged commit cde7a7b into next Feb 23, 2019
@shilman shilman deleted the 5597-toolbar-separators branch February 23, 2019 06:56
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 23, 2019
shilman added a commit that referenced this pull request Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants