-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5597 toolbar separators #5711
Merged
Merged
5597 toolbar separators #5711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domyen
requested review from
danielduan,
Hypnosphi,
igor-dv,
ndelangen,
tmeasday and
usulpro
as code owners
February 21, 2019 19:45
Codecov Report
@@ Coverage Diff @@
## next #5711 +/- ##
=========================================
+ Coverage 33.28% 33.3% +0.02%
=========================================
Files 648 648
Lines 9371 9373 +2
Branches 1355 1331 -24
=========================================
+ Hits 3119 3122 +3
+ Misses 5637 5636 -1
Partials 615 615
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Feb 21, 2019
Keraito
approved these changes
Feb 21, 2019
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5597
What I did
How to test
See changes in Chromatic and approve