Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar should not have separators between each addon icon #5597

Closed
domyen opened this issue Feb 15, 2019 · 4 comments
Closed

Toolbar should not have separators between each addon icon #5597

domyen opened this issue Feb 15, 2019 · 4 comments
Labels
Milestone

Comments

@domyen
Copy link
Member

domyen commented Feb 15, 2019

Describe the bug
Icons in the toolbar should not have separators between each of them. Separators should only appear if there are more than two icons present in a feature or addon (i.e., like the Zoom feature).

To Reproduce
Steps to reproduce the behavior:

  1. Go to Storybook that has Toolbar addons
  2. See that each icon that corresponds to addons has a toolbar between it

Expected behavior
There shouldn't be separators here:
image
or here
image

@domyen domyen added this to the v5.0.0 milestone Feb 15, 2019
@leoyli
Copy link
Contributor

leoyli commented Feb 16, 2019

But I think they are nice to have, at least it is clear to me what kind of add-on are grouped...?!

@domyen
Copy link
Member Author

domyen commented Feb 18, 2019

Each icon already represents discrete functionality - they don't need to be further separated from other icons to achieve that.

So they end up occupying more horizontal space yet don't communicating anything new.

@ndelangen
Copy link
Member

This is fixed?

@shilman
Copy link
Member

shilman commented Feb 23, 2019

Yowza!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.5 containing PR #5711 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants