Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring UI Components and adding more stores #5404

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 30, 2019

cc @domyen @ndelangen

Re-target this PR to next once #5372 is merged

@tmeasday tmeasday added this to the v5.0.0 milestone Jan 30, 2019
@ndelangen ndelangen changed the base branch from tech/v5-theming to next January 30, 2019 16:26
@ndelangen ndelangen self-assigned this Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #5404 into next will increase coverage by 0.2%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #5404     +/-   ##
=========================================
+ Coverage   30.84%   31.05%   +0.2%     
=========================================
  Files         622      625      +3     
  Lines        9158     9180     +22     
  Branches     1302     1302             
=========================================
+ Hits         2825     2851     +26     
+ Misses       5687     5685      -2     
+ Partials      646      644      -2
Impacted Files Coverage Δ
.../ui/src/components/nav/NotificationList.stories.js 100% <100%> (ø)
.../ui/src/components/nav/NotificationItem.stories.js 100% <100%> (ø)
lib/ui/src/components/nav/nav.js 100% <100%> (+12.5%) ⬆️
lib/ui/src/components/nav/NotificationList.js 83.33% <83.33%> (ø)
lib/ui/src/components/nav/NotificationItem.js 92.3% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bce5f...170e485. Read the comment docs.

@ndelangen ndelangen merged commit b997180 into next Jan 30, 2019
@ndelangen ndelangen deleted the add-more-stories branch January 30, 2019 17:25
@shilman shilman added maintenance User-facing maintenance tasks and removed feature request labels Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants