-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech/v5 theming - treeview & preview #5372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
danielduan,
Hypnosphi,
igor-dv,
jbovenschen,
shilman,
tmeasday and
usulpro
as code owners
January 25, 2019 13:01
ndelangen
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
January 25, 2019 13:49
Need to remove the old colors, but will slowly replace them as I style the UI
ndelangen
changed the title
Tech/v5 theming - treeview
Tech/v5 theming - treeview & preview
Jan 28, 2019
Component is erroring because it doesn't recognize babel-plugin-emotion. Do I need to install it somewhere else beside /storybook? @ndelangen
…ging the propType of tabs
# Conflicts: # yarn.lock
Codecov Report
@@ Coverage Diff @@
## next #5372 +/- ##
=========================================
+ Coverage 30.54% 30.84% +0.3%
=========================================
Files 621 622 +1
Lines 8939 9158 +219
Branches 1248 1302 +54
=========================================
+ Hits 2730 2825 +95
- Misses 5566 5687 +121
- Partials 643 646 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixing some design issues && REFACTOR treeview