Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/v5 theming - treeview & preview #5372

Merged
merged 65 commits into from
Jan 30, 2019
Merged

Tech/v5 theming - treeview & preview #5372

merged 65 commits into from
Jan 30, 2019

Conversation

ndelangen
Copy link
Member

Issue: fixing some design issues && REFACTOR treeview

@ndelangen ndelangen added ui maintenance User-facing maintenance tasks labels Jan 25, 2019
@ndelangen ndelangen added this to the v5.0.0 milestone Jan 25, 2019
@ndelangen ndelangen self-assigned this Jan 25, 2019
@ndelangen ndelangen changed the title Tech/v5 theming - treeview Tech/v5 theming - treeview & preview Jan 28, 2019
@ndelangen ndelangen requested a review from rhalff as a code owner January 29, 2019 00:15
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #5372 into next will increase coverage by 0.3%.
The diff coverage is 53.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #5372     +/-   ##
=========================================
+ Coverage   30.54%   30.84%   +0.3%     
=========================================
  Files         621      622      +1     
  Lines        8939     9158    +219     
  Branches     1248     1302     +54     
=========================================
+ Hits         2730     2825     +95     
- Misses       5566     5687    +121     
- Partials      643      646      +3
Impacted Files Coverage Δ
addons/actions/src/manager.js 0% <ø> (ø) ⬆️
addons/a11y/src/components/Panel.js 0% <ø> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <ø> (ø) ⬆️
lib/ui/src/components/nav/notifications.js 66.66% <ø> (ø) ⬆️
lib/components/src/icon/icon.js 100% <ø> (ø) ⬆️
lib/ui/src/components/layout/container.js 20.37% <ø> (ø) ⬆️
lib/ui/src/settings/about.js 70% <ø> (-30%) ⬇️
.../components/src/panel_actionbar/panel_actionbar.js 100% <ø> (ø) ⬆️
lib/ui/src/components/layout/draggers.js 9.09% <ø> (+0.75%) ⬆️
lib/ui/src/settings/shortcuts.js 90.56% <ø> (-5.27%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4521c...25fc785. Read the comment docs.

@ndelangen ndelangen merged commit d5bce5f into next Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants