Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "@types/react" to dev dependencies #3169

Merged
merged 4 commits into from
Mar 8, 2018
Merged

Move "@types/react" to dev dependencies #3169

merged 4 commits into from
Mar 8, 2018

Conversation

MLoughry
Copy link
Contributor

@MLoughry MLoughry commented Mar 7, 2018

Issue: @types/react is listed as an optional dependency in addon-notes, which can cause type conflicts to any downstream consumer with a different types version

What I did

Moved the dependency to devDependencies

How to test

Build

Is this testable with jest or storyshots? No

Does this need a new example in the kitchen sink apps? No

Does this need an update to the documentation? No

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #3169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3169   +/-   ##
=======================================
  Coverage   36.03%   36.03%           
=======================================
  Files         437      437           
  Lines        9464     9464           
  Branches      888      887    -1     
=======================================
  Hits         3410     3410           
+ Misses       5493     5476   -17     
- Partials      561      578   +17
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 48.64% <0%> (ø) ⬆️
addons/actions/src/lib/types/function/index.js 77.77% <0%> (ø) ⬆️
addons/knobs/src/components/types/Button.js 11.9% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 84.25% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d06f6d...535f2a3. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think it was here by mistake.
Thanks.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MLoughry !

@Hypnosphi Hypnosphi merged commit 86b16c8 into storybookjs:master Mar 8, 2018
@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 8, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: notes dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants