-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "@types/react" to dev dependencies #3169
Move "@types/react" to dev dependencies #3169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3169 +/- ##
=======================================
Coverage 36.03% 36.03%
=======================================
Files 437 437
Lines 9464 9464
Branches 888 887 -1
=======================================
Hits 3410 3410
+ Misses 5493 5476 -17
- Partials 561 578 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think it was here by mistake.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MLoughry !
Issue:
@types/react
is listed as an optional dependency inaddon-notes
, which can cause type conflicts to any downstream consumer with a different types versionWhat I did
Moved the dependency to devDependencies
How to test
Build
Is this testable with jest or storyshots? No
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? No