Rename docsPage => autodocs
#20364
Merged
Rename docsPage => autodocs
#20364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And change semantics: `docsPage:true` = `autodocs: 'tag'` and `docsPage: 'automatic'` = `autodocs: true`.
jonniebigodes
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
@tmeasday, thanks for taking care of this. Looks good to me! I'll take a pass at the rest of the docs (i.e., doc blocks) and adjust accordingly.
…me-docspage-autodocs
Co-authored-by: Michael Shilman <[email protected]>
…me-docspage-autodocs
Base automatically changed from
tom/sb-973-rename-docsenabled-to-docsdisable
to
next
December 22, 2022 05:45
|
@tmeasday can you change the automigration so it migrates docsPage automatic to autodocs too? Users will get confused, and they probably need to update their stories too? |
|
Sure: #20379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Telescoping on #20363
What I did
Changed:
-
docsPage: true=>autodocs: 'tag'-
docsPage: 'automatic'=>autodocs: true.I didn't really properly look at the docs yet, I think a second pass over the docs alongside doc blocks changes makes sense. (cc @jonniebigodes though).
How to test
Hopefully unit tests should catch this.