Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docsOptions.enabled to docsOptions.disable #20363

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

tmeasday
Copy link
Member

Issue: N/A

What I did

Rename option to be more consistent with other options

How to test

Try disabling docs with docs: { disable: true }

@tmeasday tmeasday requested a review from shilman December 21, 2022 10:28
@tmeasday tmeasday added maintenance User-facing maintenance tasks addon: docs labels Dec 21, 2022
@tmeasday tmeasday force-pushed the tom/sb-973-rename-docsenabled-to-docsdisable branch from 427ec44 to ed18a8d Compare December 21, 2022 10:51
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo

code/lib/core-server/src/utils/StoryIndexGenerator.test.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday merged commit f094218 into next Dec 22, 2022
@tmeasday tmeasday deleted the tom/sb-973-rename-docsenabled-to-docsdisable branch December 22, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants