-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed lifecycle twice executing (close #1742) #1983
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1983 +/- ##
=======================================
Coverage 21.34% 21.34%
=======================================
Files 262 262
Lines 5767 5767
Branches 696 705 +9
=======================================
Hits 1231 1231
+ Misses 4005 3987 -18
- Partials 531 549 +18
Continue to review full report at Codecov.
|
@@ -67,6 +67,8 @@ export function renderMain(data, storyStore) { | |||
// https://github.com/storybooks/react-storybook/issues/81 | |||
previousKind = selectedKind; | |||
previousStory = selectedStory; | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not also a valid change for react? totally guessing here.
either way this PR is good to merge, as it addresses a very nasty bug for Vue users!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, In the Vue, occure the similar issues.
What I did
Fixed #1742
How to test
add the below
created
hook:On the browser, the below actions
console
tabAfter that, in the output of the console, output
call created hook
once only