Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lifecycle twice executing (close #1742) #1983

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Fixed lifecycle twice executing (close #1742) #1983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f450809
:bug: bug(vue): fixed lifecycle twice executing
kazupon Oct 6, 2017
baddc70
Merge branch 'master' into fixes/issue-1742
ndelangen Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/vue/src/client/preview/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ export function renderMain(data, storyStore) {
// https://github.com/storybooks/react-storybook/issues/81
previousKind = selectedKind;
previousStory = selectedStory;
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not also a valid change for react? totally guessing here.

either way this PR is good to merge, as it addresses a very nasty bug for Vue users!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, In the Vue, occure the similar issues.

return;
}

const context = {
Expand Down