Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the reporter dynamic #19587

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Conversation

ndelangen
Copy link
Member

I made it so when running the e2e test locally you get a human readable output

@ndelangen ndelangen requested a review from tmeasday October 23, 2022 10:26
@ndelangen ndelangen self-assigned this Oct 23, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 23, 2022
@ndelangen ndelangen merged commit 8d95548 into next Oct 23, 2022
@ndelangen ndelangen deleted the tech/html-reporter-for-e2e-tests-locally branch October 23, 2022 10:58
@@ -10,8 +10,10 @@ export const e2eTests: Task = {
return false;
},
async run({ codeDir, junitFilename, template }, { dryRun, debug }) {
const reporter = process.env.CI ? 'junit' : 'html';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we switch on junitFilename here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants